fix(lib): inline references in strings should not destroy string itself #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorfmann
approved these changes
Dec 9, 2021
DanielMSchmidt
deleted the
bug-removing-string-fragments-from-strings-with-inlined-terraform-references
branch
jsteinich
reviewed
Dec 10, 2021
| // if left is only a token, needs to be wrapped as terraform expression | ||
| if (leftTokenList.literals.length === 0 && leftTokenCount === 1) { | ||
| leftValue = `\${${leftTokens[0]}}`; | ||
| } | ||
|
|
||
| const rightValue = |
There was a problem hiding this comment.
Could the same issue happen with the right side?
There was a problem hiding this comment.
No, the token list is joined from left to right
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this bug while iterating on cross stack references