Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(docs): Final Docs Migration Cleanup #1431

Merged
merged 13 commits into from
Jan 18, 2022
Merged

chore(docs): Final Docs Migration Cleanup #1431

merged 13 commits into from
Jan 18, 2022

Conversation

laurapacilio
Copy link
Contributor

@laurapacilio laurapacilio commented Dec 20, 2021 •
edited
Loading

This PR addresses the final tasks required to finish the docs migration from GitHub to terraform.io. Specifically, it:

  • Adds a section to the Project Setup page about the synth command. This is part of ensuring that the content on this page is properly documented on terraform.io
  • Adds a releases section to the docs that includes an overview page where we link to the changelog, to the upgrade guides, and mention feature flags. It also migrates the upgrade guides to the docs site (they will be child pages of "Releases".
  • Updates the sidebar files to include the new pages 🥳

@schersh
Copy link
Contributor

schersh commented Dec 21, 2021

Thanks @laurapacilio - looking good so far!

@laurapacilio laurapacilio marked this pull request as ready for review January 14, 2022 17:16
ansgarm
ansgarm approved these changes Jan 17, 2022
View reviewed changes
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @laurapacilio!

website/docs/cdktf/create-and-deploy/configuration-file.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/create-and-deploy/configuration-file.mdx Outdated Show resolved Hide resolved
website/docs/cdktf/release/index.mdx Outdated Show resolved Hide resolved
laurapacilio and others added 4 commits January 18, 2022 10:20
@laurapacilio @ansgarm
Update website/docs/cdktf/create-and-deploy/configuration-file.mdx
0dc782a 
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
@laurapacilio @ansgarm
Update website/docs/cdktf/create-and-deploy/configuration-file.mdx
9243e87 
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
@laurapacilio @ansgarm
Update website/docs/cdktf/release/index.mdx
e5d67d7 
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
@DanielMSchmidt
Merge branch 'main' into final-migration-cleanup
f5a9a0e
@DanielMSchmidt DanielMSchmidt merged commit 3c9d248 into main Jan 18, 2022
@DanielMSchmidt DanielMSchmidt deleted the final-migration-cleanup branch January 18, 2022 15:24
@ansgarm ansgarm mentioned this pull request Jan 26, 2022
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ansgarm ansgarm ansgarm approved these changes

@schersh schersh Awaiting requested review from schersh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@laurapacilio @schersh @ansgarm @DanielMSchmidt