Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(provider-generator): remove .html suffix for doc links #1438

Merged
merged 4 commits into from
Jan 3, 2022

Conversation

Tucker-Eric
Copy link
Contributor

Terraform registry docs show 404 for docs with a .html suffix, this removes .html suffix from linkToDocs.

Doc links in comments before: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_object.html#bucket
Doc links in comments after: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/s3_bucket_object#bucket

@hashicorp-cla
Copy link

hashicorp-cla commented Dec 27, 2021

CLA assistant check
All committers have signed the CLA.

@Tucker-Eric Tucker-Eric changed the title Update resource-model.ts fix(docs): Update resource-model.ts Dec 27, 2021
Copy link
Collaborator

@jsteinich jsteinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

There are a bunch of snapshots which change with this. They can be updated by running yarn test -u

@Tucker-Eric
Copy link
Contributor Author

yarn test:update seems to have done the trick. It looks like the 2 failing tests are version mismatches and not snapshot issues.

Copy link
Contributor

@DanielMSchmidt DanielMSchmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a ton 👍 🎉

@DanielMSchmidt DanielMSchmidt changed the title fix(docs): Update resource-model.ts fix(provider-generator): remove .html suffix for doc links Jan 3, 2022
@DanielMSchmidt DanielMSchmidt merged commit dd11c6a into hashicorp:main Jan 3, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants