fix(cli): speed up shell autocompletions #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Speed up shell autocompletions by pulling actual handler code into a separate entrypoint which is only required when it is going to be invoked. When testing this speed up shell completions by 6x (from 1.2s to 0.2s [locally on OS X]). The main reason seemed to be e.g. the React package required by e.g. ink which is deffered into a separate bundle / entrypoint now. Also `inquirer` seems to have been quite a burden (used in `init`).
ansgarm
force-pushed
the
speed-up-shell-completions
branch
from
106221b
to
c0f9a83
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speed up shell autocompletions by pulling actual handler code into
a separate entrypoint which is only required when it is going to be
invoked. When testing this sped up shell completions by 6x (from
1.2s to 0.2s [locally on OS X]). The main reason seemed to be e.g.
the React package required by e.g. ink which is deffered into a
separate bundle / entrypoint now. Also
inquirerseems to have beenquite a burden (used in
init).Closes #1039