refactor: separate logic from UI layer #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
force-pushed
the
refactor-cli
branch
7 times, most recently
from
b059f10
to
8915a03
Compare
DanielMSchmidt
force-pushed
the
refactor-cli
branch
9 times, most recently
from
b7d6e92
to
b03f839
Compare
DanielMSchmidt
force-pushed
the
refactor-cli
branch
7 times, most recently
from
afda4ca
to
2f64b97
Compare
DanielMSchmidt
force-pushed
the
refactor-cli
branch
2 times, most recently
from
ac2cc33
to
9ab25db
Compare
ansgarm
reviewed
Feb 18, 2022
ansgarm
reviewed
Feb 18, 2022
There was a problem hiding this comment.
Nice work @DanielMSchmidt 🎉
(a first review, I got through roughly half of it)
DanielMSchmidt
force-pushed
the
refactor-cli
branch
2 times, most recently
from
9f381a7
to
cf59062
Compare
Co-authored-by: Ansgar Mertens <ansgar@hashicorp.com>
due to some weak typings we have to use a lot of ! syntax in this file
DanielMSchmidt
force-pushed
the
refactor-cli
branch
from
53dea13
to
1fa078f
Compare
ansgarm
approved these changes
Feb 24, 2022
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The goal of this PR is to separate our CLI rendering from the code that does the work. This makes each part easier to test and provides a stepping stone in the direction of a driving the CLI from node.js.