Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): add docstrings to artifactory/azurerm/consul backend resources #1781

Merged
merged 1 commit into from
May 9, 2022

Conversation

aayushharwani-aidash
Copy link
Contributor

@aayushharwani-aidash aayushharwani-aidash commented May 6, 2022

Have added doc-string to artifactory,azurerm and consul backend resources

Working on issue - #1268

@aayushharwani-aidash
Copy link
Contributor Author

@ansgarm

Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @aayushharwani-aidash 👏
Just two small things for parity.

@aayushharwani-aidash
Copy link
Contributor Author

@ansgarm made changes, as suggested by you.

Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's remove the empty lines between the text and the link and we're good to go 👍

packages/cdktf/lib/backends/azurerm-backend.ts Outdated Show resolved Hide resolved
packages/cdktf/lib/backends/consul-backend.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants