Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hcl2cdk): use the same attribute renaming function as in the provider generation #1842

Conversation

DanielMSchmidt
Copy link
Contributor

@DanielMSchmidt DanielMSchmidt commented Jun 2, 2022

Closes #1708

@DanielMSchmidt DanielMSchmidt force-pushed the convert-should-rename-properties-the-same-as-the-provider-generator branch from e480ec5 to 748a21d Compare June 2, 2022 14:00
@DanielMSchmidt DanielMSchmidt force-pushed the convert-should-rename-properties-the-same-as-the-provider-generator branch from 748a21d to 0d128df Compare June 10, 2022 19:58
@DanielMSchmidt DanielMSchmidt force-pushed the convert-should-rename-properties-the-same-as-the-provider-generator branch from 0d128df to 3f0cc7e Compare June 13, 2022 17:58
@DanielMSchmidt DanielMSchmidt force-pushed the convert-should-rename-properties-the-same-as-the-provider-generator branch from f78dd8c to d6793f6 Compare June 14, 2022 12:33
@DanielMSchmidt DanielMSchmidt force-pushed the convert-should-rename-properties-the-same-as-the-provider-generator branch from aa4cc14 to 4688e70 Compare June 15, 2022 16:18
@DanielMSchmidt DanielMSchmidt force-pushed the convert-should-rename-properties-the-same-as-the-provider-generator branch from 4688e70 to 31a0d57 Compare June 15, 2022 16:24
@DanielMSchmidt DanielMSchmidt force-pushed the convert-should-rename-properties-the-same-as-the-provider-generator branch from f94834b to eaf53b6 Compare June 16, 2022 09:35
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@DanielMSchmidt DanielMSchmidt merged commit 1fcbb0a into main Jun 16, 2022
@DanielMSchmidt DanielMSchmidt deleted the convert-should-rename-properties-the-same-as-the-provider-generator branch June 16, 2022 11:42
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert does not rename properties the same way as the provider generator does
2 participants