Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix watch telemetry #2698

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix(cli): fix watch telemetry #2698

merged 2 commits into from
Mar 8, 2023

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Mar 8, 2023

Description

When we refactored watch to get rid of the GraphQL experiment, we accidentally removed the telemetry related things as
well

Checklist

  • I have updated the PR title to match CDKTF's style
    guide
  • I have run the linter on my code locally
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if applicable
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works if applicable
  • New and existing unit tests pass locally with my changes

Copy link
Member

@mutahhir mutahhir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SynthOrigin is a bit confusing as a name (I thought it was going to be referring to a hostname at some point), but it's a minor nit and I don't have a much better alternative (SynthCommand etc), so approving now.

@ansgarm
Copy link
Member Author

ansgarm commented Mar 8, 2023

Yeah, that was my past self that named it like that (it was still part of the Stack.synth() interface, so I kept it)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2023

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants