refactor(hcl2json): rename wasm method to match its implementation and expose it more direct aswell #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
requested review from
mutahhir and
DanielMSchmidt
and removed request for
a team
ansgarm
changed the title
ansgarm
commented
Mar 15, 2023
ansgarm
force-pushed
the
small-cleanup-hcl2json
branch
from
1657128
to
c544761
Compare
DanielMSchmidt
approved these changes
Mar 15, 2023
…d expose it more direct aswell
… Print warning too in that case this also adjusts the test cases to test that the warning gets printed as that's a regression that has been fixed in this PR
ansgarm
force-pushed
the
small-cleanup-hcl2json
branch
from
c544761
to
d859f11
Compare
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR prepares the library for the convert work that's going to happen to support e.g. replacing functions and operations.