-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Specific imports for convert #2946
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
force-pushed
the
feat/specific-imports
branch
from
June 19, 2023 08:33
08a0db4
to
77866c8
Compare
mutahhir
requested review from
ansgarm and
DanielMSchmidt
and removed request for
a team
June 20, 2023 11:06
DanielMSchmidt
approved these changes
Jun 20, 2023
ansgarm
added a commit
that referenced
this pull request
Jun 23, 2023
ansgarm
added a commit
that referenced
this pull request
Jun 23, 2023
ansgarm
added a commit
that referenced
this pull request
Jun 23, 2023
ansgarm
added a commit
that referenced
this pull request
Jun 23, 2023
Merged
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #2647
Description
This PR adds support for specific imports when using
cdktf convert
. This has the following benefits. Firstly the code is more idomatic, and what we recommend people to write, rather than doing a default import of entire providers. Secondly, this unlocks code generation that works well with C# which does not have star imports.This also couples with #2935 that updates the imports to the correct destination path per language
Checklist