fix(lib): Fix handling of replaceTriggeredBy lifecycle attribute

packages/cdktf/lib/terraform-data-source.ts

@@ -9,6 +9,7 @@ import {
   TerraformResourceConfig,
   TerraformResourceLifecycle,
   ITerraformResource,
+  lifecycleToTerraform,
 } from "./terraform-resource";
 import { keysToSnakeCase, deepMerge, processDynamicAttributes } from "./util";
 import { ITerraformDependable } from "./terraform-dependable";
@@ -115,7 +116,7 @@ export class TerraformDataSource
         ? this.count.toTerraform()
         : this.count,
       provider: this.provider?.fqn,
-      lifecycle: this.lifecycle,
+      lifecycle: lifecycleToTerraform(this.lifecycle),
       forEach: this.forEach?._getForEachExpression(),
     };
   }

packages/cdktf/lib/terraform-resource.ts

@@ -50,6 +50,34 @@ export interface TerraformResourceLifecycle {
   readonly postcondition?: Postcondition[];
 }
 
+/**
+ * prepares a lifecycle object for being rendered as JSON
+ * currently this function:
+ *  - converts all replaceTriggeredBy items that are ITerraformDependables to strings
+ */
+export function lifecycleToTerraform(
+  lifecycle?: TerraformResourceLifecycle
+): TerraformResourceLifecycle | undefined {
+  if (!lifecycle) {
+    return undefined;
+  }
+
+  return {
+    ...lifecycle,
+    ...(lifecycle?.replaceTriggeredBy?.length
+      ? {
+          replaceTriggeredBy: lifecycle?.replaceTriggeredBy?.map((x) => {
+            if (typeof x === "string") {
+              return x;
+            } else {
+              return x.fqn;
+            }
+          }),
+        }
+      : undefined),
+  };
+}
+
 export interface TerraformMetaArguments {
   readonly dependsOn?: ITerraformDependable[];
   readonly count?: number | TerraformCount;
@@ -190,13 +218,14 @@ export class TerraformResource
       !this.forEach || typeof this.count === "undefined",
       `forEach and count are both set, but they are mutually exclusive. You can only use either of them. Check the resource at path: ${this.node.path}`
     );
+
     return {
       dependsOn: this.dependsOn,
       count: TerraformCount.isTerraformCount(this.count)
         ? this.count.toTerraform()
         : this.count,
       provider: this.provider?.fqn,
-      lifecycle: this.lifecycle,
+      lifecycle: lifecycleToTerraform(this.lifecycle),
       forEach: this.forEach?._getForEachExpression(),
       connection: this.connection,
     };

packages/cdktf/test/__snapshots__/resource.test.ts.snap

@@ -440,6 +440,40 @@ exports[`supports local-exec provisioner 1`] = `
 }"
 `;
 
+exports[`supports resource and attribute references in lifecycle.replaceTriggeredBy 1`] = `
+"{
+  "provider": {
+    "test": [
+      {
+      }
+    ]
+  },
+  "resource": {
+    "test_resource": {
+      "other": {
+        "name": "other"
+      },
+      "simple": {
+        "lifecycle": {
+          "replace_triggered_by": [
+            "\${test_resource.other}",
+            "\${test_resource.other.string_value}"
+          ]
+        },
+        "name": "foo"
+      }
+    }
+  },
+  "terraform": {
+    "required_providers": {
+      "test": {
+        "version": "~> 2.0"
+      }
+    }
+  }
+}"
+`;
+
 exports[`with complex computed list 1`] = `
 "{
   "provider": {

packages/cdktf/test/resource.test.ts

@@ -328,6 +328,23 @@ it("maintains the same order of provisioner", () => {
   expect(Testing.synth(stack)).toMatchSnapshot();
 });
 
+it("supports resource and attribute references in lifecycle.replaceTriggeredBy", () => {
+  const app = Testing.app();
+  const stack = new TerraformStack(app, "test");
+  new TestProvider(stack, "provider", {});
+
+  const other = new TestResource(stack, "other", { name: "other" });
+
+  new TestResource(stack, "simple", {
+    name: "foo",
+    lifecycle: {
+      replaceTriggeredBy: [other, other.stringValue],
+    },
+  });
+
+  expect(Testing.synth(stack)).toMatchSnapshot();
+});
+
 test("includes import block when import is present", () => {
   const app = Testing.app();
   const stack = new TerraformStack(app, "test");