fix: Map keys not being quoted when they are not valid identifiers #3464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mutahhir
requested review from
DanielMSchmidt and
Maed223
and removed request for
a team
ansgarm
approved these changes
Jan 25, 2024
DanielMSchmidt
approved these changes
Jan 25, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
mutahhir
force-pushed
the
fix/wrap-non-identifier-keys
branch
from
65a692c to
c8b29bc
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #3459
Description
Terraform expects keys of maps to be valid identifiers, and the HCL synth was not ensuring that before. This PR tries to detect areas where quoting is required to ensure valid HCL is output.