chore: fix branch cleanup #3644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a revert is using a part of the branch name it leads to problems in the cleanup since the matched part is what we assume is the branch name and that one does not exist. The origin/ should make sure that there can be no prefix, technically we should also guard against suffixes bug we'll cross that bridge when we get there
DanielMSchmidt
requested review from
mutahhir and
ansgarm
and removed request for
a team
ansgarm
approved these changes
Jun 10, 2024
ansgarm
added a commit
that referenced
this pull request
Jul 1, 2024
## 0.20.8 ### feat - feat: add validation to TerraformModule [\#3608](#3608) ### fix - fix: Empty string, booleans, and zero numbers in hcl rendering [\#3655](#3655) - fix: explicitly listen on ipv4 address for verdaccio due to Github runner image regression [\#3654](#3654) ### chore - chore: manifest.json should have stable json [\#3584](#3584) - chore: update JSII [\#3616](#3616) - chore: remove dependency on jsii-srcmak [\#3607](#3607) - chore: Fix a small documentation typo [\#3629](#3629) - chore: Use single-label runner for custom-linux-xl [\#3623](#3623) - chore: fix branch cleanup [\#3644](#3644) - chore: remove Homebrew link and publishing step [\#3605](#3605) - chore: Upgrade dependencies for lib [\#3618](#3618) - chore: Upgrade dependencies for util [\#3599](#3599) - chore: Upgrade dependencies for util [\#3589](#3589) - chore: Upgrade dependencies for util [\#3612](#3612) - chore: Upgrade dependencies for cli [\#3613](#3613) - chore: Upgrade dependencies for cli [\#3598](#3598) - chore: Add links and headers [\#3594](#3594) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3614](#3614) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3606](#3606) - chore(deps): pin trusted workflows based on HashiCorp TSCCR [\#3652](#3652)
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when a revert is using a part of the branch name it leads to problems in the cleanup
since the matched part is what we assume is the branch name and that one does not exist.
The origin/ should make sure that there can be no prefix, technically we should also guard against suffixes bug we'll cross that bridge when we get there