-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: reorganize API documentation #3668
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Nice work 👍
Only a small question about the new dependencies and one about the now 404-ing paths
@@ -173,27 +173,132 @@ | |||
"routes": [ | |||
{ | |||
"title": "Overview", | |||
"path": "api-reference/overview" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can / Should we redirect this to just api-reference
for old links to still work?
}, | ||
{ | ||
"title": "Typescript", | ||
"path": "api-reference/typescript" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as for the overview page – can / should we add redirects to just api-reference
?
9ddeec3
to
445aa65
Compare
Merging this, @trujillo-adam could you do a quick follow up with the redirects @ansgarm mentioned (we have no idea how those work and figured maybe you do 🙈 ) |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This PR contains changes from the last successful commit in PR 3659. The changes present separate pages for the resources in each language in the API reference. This is a temporary fix for the documentation until @DanielMSchmidt finishes updating the API reference documentation generator.