Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checkpoint Error Handling / Timeout #552

Merged
merged 7 commits into from
Feb 9, 2021
Merged

Conversation

skorfmann
Copy link
Contributor

This PR adds proper error handling for the request object plus a timeout of 1s. This will silently ignore errors when Checkpoint isn't reachable for some reason.

Furthermore, this cleans up a bit of obsolete code and reorganizes deps / devDeps.

Fixes: #351
Related to: #544

skorfmann added a commit that referenced this pull request Feb 8, 2021
Gonna move this to a unit test in #552
This replaces an integration test removed in 74b2186
@skorfmann skorfmann requested a review from jsteinich February 8, 2021 20:02
Copy link
Collaborator

@jsteinich jsteinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't really used that request method before, but seems fine.

@skorfmann skorfmann merged commit 78c5786 into main Feb 9, 2021
@skorfmann skorfmann deleted the checkpoint-error-handling branch February 9, 2021 14:05
@skorfmann skorfmann mentioned this pull request Mar 11, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running under the proxy
2 participants