Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Integration Tests to Jest #567

Merged
merged 10 commits into from
Feb 22, 2021
Merged

Conversation

skorfmann
Copy link
Contributor

While working on the Ink v3 upgrade (#559) I got pretty annoyed by the current state of integration tests. As part of #559, I made a little proof of concept for using Jest as the test orchestrator for the integration tests and it turned out pretty good. This PR migrates all existing integration tests.

The main benefits include:

  • Easier to manage diffs thanks to Jest snapshots
  • Runs on Linux / Windows out of the box
  • Less and simpler code / Way less bash scripting

This is supposed to be merged into #559

@skorfmann skorfmann force-pushed the end2end-tests-in-jest branch from 5c33922 to 11a14a3 Compare February 19, 2021 14:37
@skorfmann skorfmann requested a review from jsteinich February 19, 2021 15:32
@skorfmann skorfmann requested a review from jsteinich February 22, 2021 13:33
Copy link
Collaborator

@jsteinich jsteinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for adding that test.

@skorfmann skorfmann merged commit 97ccbe6 into upgrade-ink Feb 22, 2021
@skorfmann skorfmann deleted the end2end-tests-in-jest branch February 22, 2021 13:52
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants