Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing handling for resource status lines #619

Merged

Conversation

sergeyzenchenko
Copy link
Contributor

Still creating... and Still destroying... were not handled. If resource took long enough time to create or destroy it went from "Creating" state to "Waiting" state.

Probably cause of #403

@jsteinich
Copy link
Collaborator

Thank you for your contribution.

Do you have evidence that this fixes #403? I would have expected the switch to hit the default waiting state which I would anticipate eventually resulting in one of the completed states.

@sergeyzenchenko
Copy link
Contributor Author

I don't have clear evidence for this specific case. But in my deployment resource were in waiting state until they eventually all deployed. It looks similar, but information in in issue is not enough to fully understand it.

@sergeyzenchenko
Copy link
Contributor Author

Also I've observed same behaviour with Summary area not displaying correct numbers. After this fix I see all updates and summary properly

@skorfmann skorfmann merged commit 4f450fc into hashicorp:main Apr 7, 2021
@ansgarm ansgarm mentioned this pull request Apr 13, 2021
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants