feat: add support for remote templates #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently supports specifying a public url to a zip file refactored some test helper methods to be async because else they block the js main loop and the template-server could not serve the request for a template zip file
skorfmann
reviewed
Apr 20, 2021
apparently jest does not wait for an async function to complete in BeforeAll hooks (see: jestjs/jest#9527). With the default timeout of 5 seconds this had the effect of our test cases being run without initialization to be complete. this was no issue prior as we used to use execSync which blocked the whole js main loop and thereby also blocked jest in running our test cases. switched exec to spawn for some test-helper shell calls. this allows to capture all logs and can also allow to print them as they appear (line per line) which helped discover the cause of the jest related issue
ansgarm
force-pushed
the
ansgarm/issue339
branch
from
335e076 to
47bfcca
Compare
skorfmann
reviewed
Apr 21, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently supports specifying a public url pointing to a zip file.
Refactored some test helper methods to be async because else they block the js main loop and the template-server utility class could not serve the request for a template zip file.
Closes #339.
To test this locally, you can use this url to a copy of our typescript template:
Open tasks
sscaff