Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return non-zero exit code on unknown command and allow terraform-like command names #680

Merged
merged 2 commits into from
May 3, 2021

Conversation

DanielMSchmidt
Copy link
Contributor

Fixes #675,#573

I was unsuccessful in getting yargs.showHelp to show the commands, I feel like this iteration is a good step forward already :)

@DanielMSchmidt DanielMSchmidt force-pushed the fix-675-unknown-command-no-error branch from 3a3054a to d7374d8 Compare May 3, 2021 13:58
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@ansgarm ansgarm merged commit e7c3aa4 into main May 3, 2021
@ansgarm ansgarm deleted the fix-675-unknown-command-no-error branch May 3, 2021 14:24
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdktf plan does nothing and returns exit code 0
2 participants