fix(hcl2cdk): only run get conditionally #846
Merged
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteinich
reviewed
Jul 26, 2021
Comment on lines
148
to
150
| const { terraformModules, terraformProviders } = JSON.stringify( | ||
| cdktfJson | ||
| ) as any; |
There was a problem hiding this comment.
Why not just check the object directly?
There was a problem hiding this comment.
you mean config.terraformModules etc?
There was a problem hiding this comment.
I mean why convert cdktfJson to a string when it is already an object?
DanielMSchmidt
force-pushed
the
check-before-cdktf-get
branch
4 times, most recently
from
e8a7179 to
143009e
Compare
DanielMSchmidt
force-pushed
the
check-before-cdktf-get
branch
from
143009e to
e685b5a
Compare
ansgarm
reviewed
Jul 29, 2021
ansgarm
reviewed
Jul 29, 2021
Comment on lines
+305
to
+306
| terraformProviders: any[]; | ||
| terraformModules: any[]; |
There was a problem hiding this comment.
nit: they could also be undefined / not set for the input, but they won't be when they're outputted, right?
ansgarm
approved these changes
Jul 29, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix running get if there are no modules and providers added to the cdktf.json