chore(deps): add gcc and gcc-c++ to Dockerfile required for node-gyp #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-gyp is used by node-pty which is going to be used to test the interactive cdktf watch command
DanielMSchmidt
approved these changes
Jul 27, 2021
…n Docker The Asset construct failed to copy the local-asset.txt file while syntesizing after we upgraded to Node 14. It created the target file but then it blocked and the target file stayed empty. There were no visible permission errors on the source file local-asset.txt (it even worked with other files created by hand, which had the same permissions according to `ls -la` and `stat`) and it also worked on Windows and OS X. So this is going to stay a mystery for a now but we are happy that this works now
DanielMSchmidt
approved these changes
Jul 28, 2021
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-gyp is used by node-pty which is going to be used to test the interactive cdktf watch command