WrapFS: for compatibility with the stdlib io/fs package #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately we adopted a not-yet-finalized snapshot of the io/fs API and the final design doesn't quite match, and so this is a trivial adapter layer to allow passing standard library filesystems into LoadModuleFromFilesystem even though they do not (and cannot) implement our own FS interface.
apparentlymart
force-pushed
the
f-stdlib-fs
branch
from
7071e24
to
9ef9e47
Compare
infogulch
approved these changes
Oct 19, 2022
jbardin
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately in #49 we adopted a not-yet-finalized snapshot of the
io/fsAPI and the final design doesn't quite match, and so this is a trivial adapter layer to allow passing standard library filesystems intoLoadModuleFromFilesystemeven though they do not (and cannot) implement our ownFSinterface.This closes #63.