Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Hook Timeout #119

Merged
merged 4 commits into from
Nov 13, 2024
Merged

Custom Hook Timeout #119

merged 4 commits into from
Nov 13, 2024

Conversation

clairevnext
Copy link
Contributor

@clairevnext clairevnext commented Nov 11, 2024 •
edited
Loading

What

Hooks.mdx

  • added information about the new feature where a custom timeout can be set for a hook

Why

A new customer who is onboarding to TFC has a pre-plan script which takes longer than 60 seconds to run. To fix this issue we are adding the ability for the hooks to have their default timeout overridden by an environment variable.

Related

Screenshots

Merge Checklist

If items do not apply to your changes, add (N/A) and mark them as complete.

Pull Request

  • One or more labels describe the type of change (e.g. clarification) and associated product (e.g. HCP Terraform).
  • Description links to related pull requests or issues, if any.

Content

  • Redirects have been added for moved, renamed, or deleted pages. This requires a separate PR in the terraform-website repository redirects.next.js file.
  • API documentation and the API Changelog have been updated.
  • Links to related content where appropriate (e.g., API endpoints, permissions, etc.).
  • Pages with related content are updated and link to this content when appropriate.
  • Sidebar navigation files have been updated for added, deleted, reordered, or renamed pages.
  • New pages have metadata (page name and description) at the top.
  • New images are 2048 px wide. They have HashiCorp standard annotation color (#F92672) and format (rectangle with rounded corners), blurred sensitive details (e.g. credentials, usernames, user icons), and descriptive alt text in the markdown for accessibility.
  • New code blocks have the correct syntax and line breaks to eliminate horizontal scroll bars.
  • UI elements (button names, page names, etc.) are bolded.
  • The Vercel website preview successfully deployed.

Reviews

  • I or someone else reviewed the content for technical accuracy.
  • I or someone else reviewed the content for typos, punctuation, spelling, and grammar.

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terraform-docs-agents ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 6:47pm

@clairevnext clairevnext added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 11, 2024
rkoron007
rkoron007 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some small suggestions, but I think this looks great! Thanks for tagging me in!

website/docs/cloud-docs/agents/hooks.mdx Outdated Show resolved Hide resolved
website/docs/cloud-docs/agents/hooks.mdx Outdated Show resolved Hide resolved
clairevnext and others added 2 commits November 11, 2024 10:50
@clairevnext @rkoron007
chore: flip words around
7647e76 
Co-authored-by: Rose M Koron <32436232+rkoron007@users.noreply.github.com>
@clairevnext
fix: switch to active voice and present tense.
af18575
@clairevnext clairevnext changed the title Customer Hook Timeout Custome Hook Timeout Nov 11, 2024
@clairevnext clairevnext changed the title Custome Hook Timeout Custom Hook Timeout Nov 11, 2024
rkoron007
rkoron007 approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@rkoron007 rkoron007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic! Thank you so much for doing these so quickly and tagging me in to review! ✨

@clairevnext clairevnext merged commit d316fb3 into main Nov 13, 2024
5 checks passed
@clairevnext clairevnext deleted the clairevnext/hook-timeouts branch November 13, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkoron007 rkoron007 rkoron007 approved these changes

@radditude radditude radditude approved these changes

@natalie-todd natalie-todd Awaiting requested review from natalie-todd

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clairevnext @radditude @rkoron007