Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Create CODEOWNERS file #457

Merged
merged 2 commits into from
Jul 5, 2024
Merged

github: Create CODEOWNERS file #457

merged 2 commits into from
Jul 5, 2024

Conversation

xiehan
Copy link
Member

@xiehan xiehan commented May 13, 2024

No description provided.

@radeksimko radeksimko requested review from a team May 13, 2024 13:26
@bflad
Copy link
Contributor

bflad commented May 13, 2024

Are we sure this is the correct syntax?

If you want to match two or more code owners with the same pattern, all the code owners must be on the same line. If the code owners are not on the same line, the pattern matches only the last mentioned code owner.

Refer also to the currently working terraform-json CODEOWNERS: https://github.com/hashicorp/terraform-json/blob/5e08e15af60aeaeb1ee04686fbb2f6e9de819840/CODEOWNERS

@xiehan
Copy link
Member Author

xiehan commented May 13, 2024

Interesting, I hadn't seen that before, thanks for the callout!

@ansgarm ansgarm merged commit 0e8850e into main Jul 5, 2024
71 checks passed
@ansgarm ansgarm deleted the xiehan-patch-1 branch July 5, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants