Adds validation tests to clusters #31

Etiene · 2018-11-26T16:24:36Z

Finishes implementation of tests for public cluster
Fixes a few issues with generating image and parts of the tests that needed a retry
Adds a bastion host to private cluster and adapts tests to go through bastion host
Fixes private cluster. Vault was not booting because consul was not able to join the cluster. This was happening because since the cluster is private, it didn't have internet access to request cluster info. This was fixed by creating a subnet that authorizes internal calls to the google api even without internet.
Validates private cluster

Future todos:

Add artifacts logs from private cluster to circle ci. This requires implementing a function on terratest that grabs the logs through a bastion host.
Update terratest version when applicable

Once the "symlinks" branch of Terratest is merged, we can update Gopkg.toml to the new release.

It should default to regular project id if not passed

brikis98

I can't comment much on GCP stuff, but overall code LGTM!

brikis98 · 2018-11-28T16:27:49Z

test/vault_cluster_private_test.go

+	defer test_structure.RunTestStage(t, "log", func() {
+		//ToDo: Modify log retrieval to go through bastion host
+		//      Requires adding feature to terratest
+		//writeVaultLogs(t, "vaultPublicCluster", exampleDir)


Ah, interesting. The ssh functionality in Terratest should already support jump hosts... But that isn't yet supported with the file/log fetching coding.

Etiene requested a review from josh-padnick November 28, 2018 11:22

josh-padnick and others added 25 commits November 28, 2018 12:26

Add support for validating a Vault cluster.

f6fbe57

Add automated tests for the Vault private cluster.

855349b

Temporarily update Terratest to handle symlinks properly.

f228dd5

Once the "symlinks" branch of Terratest is merged, we can update Gopkg.toml to the new release.

Update terratest version

7bb2af6

Fix packer template

4a54104

Fix network project id coming blank

2a0d4db

It should default to regular project id if not passed

Fix image builds overwriting each other

bae2327

Fix instance group not being found

a70a075

Fix test not finding enough public ips

b065046

Add logparser for logs artifacts

5f9da69

Capture log on public cluster

bbe623d

Check there are three instances on instance group

b22bcb4

Fix error causing run-vault to not recognize argument and not boot vault

b2be5b7

Add syslog to artefacts

34565ab

Ensure leader node is being used to test vault

8cb4277

Fix domain used by client to contain port

6f40306

Rename packer image

4120b47

Restructure tests to use one image

49805d5

Add retries on ssh commands

6d9ae32

Fix getting instance group on logs

b137d7c

Add validation to private vault cluster test

05d17fa

Add bastion host & subnet with google access

ccaa160

Allow helper test functions to ssh through bastion

56c31bc

Validate private cluster test through bastion host

2952c8a

Add comment explaining missing logs for private cluster

e499b62

Etiene force-pushed the validation-tests branch from 5515e61 to e499b62 Compare November 28, 2018 12:27

Etiene requested a review from brikis98 November 28, 2018 16:19

brikis98 approved these changes Nov 28, 2018

View reviewed changes

Etiene merged commit cf2f75a into master Nov 28, 2018

Etiene deleted the validation-tests branch November 28, 2018 18:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds validation tests to clusters #31

Adds validation tests to clusters #31

Etiene commented Nov 26, 2018

brikis98 left a comment

brikis98 Nov 28, 2018

Adds validation tests to clusters #31

Adds validation tests to clusters #31

Conversation

Etiene commented Nov 26, 2018

brikis98 left a comment

Choose a reason for hiding this comment

brikis98 Nov 28, 2018

Choose a reason for hiding this comment