Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version output #24

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Conversation

radeksimko
Copy link
Member

This is likely to conflict with #23 - I can rebase the other one when either of these PRs are merged.


It is planned to parse the JSON output in terraform-exec at some point as per hashicorp/terraform-exec#13 and this PR would therefore support these efforts.

The struct is practically copy&paste of the one used in core:

https://github.com/hashicorp/terraform/blob/ae025248cc0712bf53c675dc2fe77af4276dd5cc/command/version.go#L26-L32

I just added omitempty to platform since that was introduced in v0.15, although I don't expect anyone will actually use these structs for marshalling.

@vancluever
Copy link
Contributor

@radeksimko I've merged your other two PRs, wanna fix this one so that it's ready to be merged?

PS: as there's possible talk about integrating this with some other core repos, I'm going to just hold off on tagging a new version for now unless it's holding up work. I'll leave it to you though to see what you want to do. Let me know!

@radeksimko
Copy link
Member Author

@vancluever Rebased.

as there's possible talk about integrating this with some other core repos, I'm going to just hold off on tagging a new version for now unless it's holding up work. I'll leave it to you though to see what you want to do. Let me know!

I am aware. We've been briefly chatting about the transition and I think we'd prefer to still cut at least one more release (0.7.0 presumably), so we can use it in hashicorp/terraform-exec#68 (just for consistency really) which in turn unblocks hashicorp/terraform-ls#323

@vancluever
Copy link
Contributor

Sounds good. I'll tag shortly!

@vancluever vancluever merged commit 970a1d2 into hashicorp:master Dec 7, 2020
@radeksimko radeksimko deleted the version-output branch December 7, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants