internal/uri: account for VSCode's over-escaping of colon

internal/uri/uri.go

@@ -130,5 +130,17 @@ func parseUri(rawUri string) (*url.URL, error) {
 	// as it is relevant in LSP (which uses the file scheme).
 	uri.Path = strings.TrimSuffix(uri.Path, "/")
 
+	// Upstream net/url parser (correctly) escapes only
+	// non-ASCII characters as per § 2.1 of RFC 3986.
+	// https://datatracker.ietf.org/doc/html/rfc3986#section-2.1
+	// Unfortunately VSCode effectively violates that section
+	// by escaping ASCII characters such as colon.
+	// See https://github.com/microsoft/vscode/issues/75027
+	//
+	// To account for this we reset RawPath which would
+	// otherwise be used by String() to effectively enforce
+	// clean re-escaping of the (unescaped) Path.
+	uri.RawPath = ""
+
 	return uri, nil
 }

internal/uri/uri_test.go

@@ -88,6 +88,11 @@ func TestPathFromURI(t *testing.T) {
 				URI:          "file:///C:/Users/Test/tf-test/",
 				ExpectedPath: `C:\Users\Test\tf-test`,
 			},
+			// Ensure over-escaped colon (which may come from VS Code) is normalized
+			{
+				URI:          "file:///C%3A/Users/With%20Space/tf-test",
+				ExpectedPath: `C:\Users\With Space\tf-test`,
+			},
 		}
 	} else {
 		// unix
@@ -142,6 +147,11 @@ func TestMustParseURI(t *testing.T) {
 			RawURI:      "file:///C:/Users/With%20Space/tf-test/file.tf",
 			ExpectedURI: "file:///C:/Users/With%20Space/tf-test/file.tf",
 		},
+		// Ensure over-escaped colon (which may come from VS Code) is normalized
+		{
+			RawURI:      "file:///C%3A/Users/With%20Space/tf-test/file.tf",
+			ExpectedURI: "file:///C:/Users/With%20Space/tf-test/file.tf",
+		},
 	}
 
 	for i, tc := range testCases {