hcl: Ignore parsing errors

This doesn't actually enable completion for invalid configs yet
but it paves the way for #56 and #57

internal/hcl/hcl.go

@@ -28,13 +28,10 @@ func (f *file) ast() (*hcllib.File, error) {
  return f.f, nil
  }
 
- hf, diags := hclsyntax.ParseConfig(f.content, f.filename, hcllib.InitialPos)
- if diags.HasErrors() {
- return nil, diags
- }
+ hf, err := hclsyntax.ParseConfig(f.content, f.filename, hcllib.InitialPos)
  f.f = hf
 
- return hf, nil
+ return f.f, err
 }
 
 func (f *file) BlockAtPosition(filePos filesystem.FilePosition) (*hcllib.Block, hcllib.Pos, error) {
@@ -49,10 +46,7 @@ func (f *file) BlockAtPosition(filePos filesystem.FilePosition) (*hcllib.Block,
 }
 
 func (f *file) blockAtPosition(pos hcllib.Pos) (*hcllib.Block, error) {
- ast, err := f.ast()
- if err != nil {
- return nil, err
- }
+ ast, _ := f.ast()
 
  if body, ok := ast.Body.(*hclsyntax.Body); ok {
  if body.SrcRange.Empty() && pos != hcllib.InitialPos {

internal/hcl/hcl_test.go

@@ -28,26 +28,11 @@ func TestFile_BlockAtPosition(t *testing.T) {
  Column: 1,
  Byte: 0,
  },
- hcl.Diagnostics{
- &hcl.Diagnostic{
- Severity: hcl.DiagError,
- Summary: "Argument or block definition required",
- Detail: "An argument or block definition is required here.",
- Subject: &hcl.Range{
- Start: hcl.Pos{
- Byte: 0,
- Column: 1,
- Line: 1,
- },
- End: hcl.Pos{
- Byte: 3,
- Column: 4,
- Line: 1,
- },
- },
- },
+ nil, // Expect errors to be ignored
+ &hcl.Block{
+ Type: "provider",
+ Labels: []string{"aws"},
  },
- nil,
  },
  {
  "valid config and position",

langserver/handlers/complete.go

@@ -48,7 +48,7 @@ func (h *logHandler) TextDocumentComplete(ctx context.Context, params lsp.Comple
 
  hclBlock, hclPos, err := hclFile.BlockAtPosition(fPos)
  if err != nil {
- return list, fmt.Errorf("finding config block failed: %s", err)
+ return list, fmt.Errorf("finding HCL block failed: %s", err)
  }
  h.logger.Printf("HCL block found at HCL pos %#v", hclPos)
 
@@ -63,6 +63,7 @@ func (h *logHandler) TextDocumentComplete(ctx context.Context, params lsp.Comple
  if err != nil {
  return list, fmt.Errorf("finding config block failed: %w", err)
  }
+ h.logger.Printf("Configuration block %q parsed", cfgBlock.BlockType())
 
  candidates, err := cfgBlock.CompletionCandidatesAtPos(hclPos)
  if err != nil {