Reference count and go to definition

[Chupaka]

In v1.4.0 (TF 0.11) I see reference count for objects and can Cmd+click any interpolation to go to object definition.

After upgrade to the latest version, I can't see any of it anymore:

Are there some settings to bring it back?

[radeksimko]

This isn't supported yet in the latest VSCode extension (v2), but it is another functionality that will be eventually implemented in the language server and - as a result - becomes available in the extension too.

I'm not sure how exactly the extension displayed the number of references in the form of annotations - that is something we might still need to implement on the extension side, but most of the work is actually finding and counting the references, which is something that will be done on the server side. For that reason I'm going to transfer this issue over to the LS repo.

[radeksimko]

Just to set the expectations right though - it's unlikely we will bring back this functionality for 0.11 or any older Terraform versions, or if we do it would be very limited. This is due to the fact that 0.11 requires entirely different parser since it uses HCL1.

[Chupaka]

That's okay, we started the process of migration from 0.11 to 0.12 and are looking for the same UX as we had with 0.11.

[H2so4]

+1 on this feature please

[sata]

Hi maintainers, thanks for this language server implementation. Are there any plans on extending the feature set anytime soon to cover go to definition and find usage similar to the plugin for Intellij?

It would be amazing to have it as a lot more editors would be able to leverage same feature set :)

[radeksimko]

Hi folks,
the following two features were shipped today in 0.19.0:

• go-to-definition (go to attribute or block from address) Go to attribute/block from reference #569
• go-to-references (go to addresses from a block or an attribute) Go to references from outermost block #572, references: use innermost target instead of outermost #580

I am currently trying to implement the reference count as a code lens and aiming for it to be part of the next release.

Thanks for your patience.

[Chupaka]

@radeksimko Yeah, thanks, checking it right now. However, can't get "Go to References" work. Can it be it works only inside a single file?

E.g. I successfully go to a variable definition in a separate file, but clicking "Go to References" on it says "No references found"

[radeksimko]

@Chupaka Navigating across files (within the same module) should work in both cases. Can you file a new issue for this one and attach the relevant config(s), please?

[radeksimko]

This was implemented as part of hashicorp/vscode-terraform#686 which was shipped in extension version 2.14.0 and #584 which was shipped in language server version 0.20.0 (yesterday's release).

There are further planned improvements in this area - feel free to subscribe to any of these issues

• Go to module output declaration from reference vscode-terraform#706
• Go to variable definition (from local module arg) vscode-terraform#670
• Go to (local) module implementation from source #558 / Go to (local) module implementation from source vscode-terraform#669
• Go to definition of variable value in tfvars #581
• Reflect convertible types in type comparison #583

or open a new one if the problem/feature isn't described in any of them.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.