Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go to (local) module implementation from source #558

Closed
radeksimko opened this issue Jun 18, 2021 · 2 comments · Fixed by #849
Closed

Go to (local) module implementation from source #558

radeksimko opened this issue Jun 18, 2021 · 2 comments · Fixed by #849
Assignees
Labels
Milestone

Comments

@radeksimko
Copy link
Member

radeksimko commented Jun 18, 2021

Use-cases

See hashicorp/vscode-terraform#669

Notes

One would be tempted to use the "go to implementation" LSP method for this but according to how it is implemented in VS Code, this may not be the appropriate use.

Screenshot 2021-06-18 at 15 43 26

It seems that this is meant to be used in contexts of "interface implementations" in languages that have interfaces, hence the plural.

Proposal

Go To Definition

Use native textDocument/definition method to associate module URIs with relevant source attribute values.

This will be surfaced as Cmd/Ctrl+click-able and via context menu in most IDEs.

@github-actions
Copy link

This functionality has been released in v0.27.0 of the language server.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants