Parse provider versions from lock file before obtaining schema #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
force-pushed
the
f-read-plugin-versions
branch
15 times, most recently
from
677e53f
to
e4b5c6d
Compare
radeksimko
force-pushed
the
f-read-plugin-versions
branch
11 times, most recently
from
548f034
to
b16cf2e
Compare
radeksimko
force-pushed
the
f-read-plugin-versions
branch
3 times, most recently
from
6315c69
to
34c82db
Compare
radeksimko
force-pushed
the
f-read-plugin-versions
branch
2 times, most recently
from
5f4a722
to
a1bacdb
Compare
dbanck
approved these changes
Aug 4, 2022
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1021 (
DependsOn)Closes #992
This introduces
ParsePluginVersionswhich can parse provider/plugin versions as encoded by any version from Terraform v0.12. Attached tests probably best explain the differences between the versions.Secondly the PR introduces
ParseProviderVersionsjob, which leverages the mentioned function to parse the versions. This becomes the only way we obtain provider versions (previously it wasterraform version -jsonas part ofGetTerraformVersionjob).Lastly I raised #1025 to further explain and eventually address the problem with path separators. With
testing/fstest(or at least for theReadDirimplementation there) we have to use both OS-specific separator, but still use/to separate the "listable" files from dirs in a dir which we'll callReadDir()on, otherwise\are treated as any other character, basically making them part of the opaque file/dir name.