Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textDocument/complete: Complete first level keywords #104

Merged
merged 3 commits into from
May 21, 2020

Conversation

radeksimko
Copy link
Member

Closes #18

As described in that issue, this only adds support for the blocks which have schema provided by providers, supporting other blocks is generally tracked under #36

UX

Screenshot 2020-05-19 at 12 26 36
Screenshot 2020-05-19 at 12 27 23

@radeksimko radeksimko added the enhancement New feature or request label May 19, 2020
@radeksimko radeksimko added this to the v0.3.0 milestone May 19, 2020
@radeksimko radeksimko requested a review from a team May 19, 2020 11:31
@radeksimko radeksimko self-assigned this May 19, 2020
@radeksimko radeksimko mentioned this pull request May 19, 2020
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm realizing its going to be harder and harder to switch to hclog if we don't soonish.

@radeksimko
Copy link
Member Author

I'm realizing its going to be harder and harder to switch to hclog if we don't soonish.

That is a good point. I'm going to create an issue for that and try to look into that for next milestone.

@radeksimko radeksimko merged commit 7ef1aa3 into master May 21, 2020
@radeksimko radeksimko deleted the f-complete-1st-lvl-kw branch May 21, 2020 06:28
@ghost
Copy link

ghost commented Jun 20, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

textDocument/complete: Complete supported first-class keywords
2 participants