Continue parsing module files on error #1172
Conversation
| return nil, nil, err | ||
| // If a file isn't accessible, continue with reading the | ||
| // remaining module files | ||
| continue |
There was a problem hiding this comment.
This makes sense for the edge case described in #1067 but have we considered what impact this would have on real *.tf files which aren't accessible, e.g. due to mis-set permissions?
I'm guessing that we are just hoping that both client and server would be aligned on the "readability" of the same file, i.e. they'd be launched under the same user and have the same level of access. i.e. if we can't index the file, it also won't come through textDocument/didOpen, right?
So probably nothing to do here - just thinking out loud about the consequences and making sure we're aligned.
One edge case which comes to mind is - what if the user changes permissions at runtime - I'm guessing that this would come through the watch event, right? And presumably it comes before didOpen event, so there should be no race condition.
There was a problem hiding this comment.
That's a valid concern, thanks for raising it. I did some testing with mis-set permissions, but I can't create a test case. It seems impossible commit such a file, because git can't access it 😅
When working with an inaccessible file, the language server will skip it, and VS Code can't open the file, so it shouldn't come through textDocument/didOpen.
If the file permissions change, the watcher will pick it up and the LS will rerun all module related jobs:
dbanck
force-pushed
the
b-handle-invalid-symlinks
branch
from
9f3709b
to
4d6d14a
Compare
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This PR changes the parsing of module files so that if we encounter an inaccessible file, we continue parsing all the other module files instead of aborting with an error.
That should improve the experience for emacs users, relying on magic symlinks to keep track of open files.
Fixes #1067
UX
Before
No features available within the module
After
