Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Terraform exec timeout configurable #134

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

radeksimko
Copy link
Member

This PR raises the default timeout from 10s to 30s to reflect the original timeout may not be sufficient for a combination of a few providers with large schemas used in the same config and slower disk I/O.

It seems pragmatic to accommodate such cases, but slow I/O is painful in general and configuration gets more fragile with more providers you add (e.g. because one API may be down, which makes applies stop half-way through etc.), so these users will suffer either way and this patch is not meant to solve all their problems, just to help them suffer less.

@radeksimko radeksimko added the enhancement New feature or request label Jun 3, 2020
@radeksimko radeksimko requested a review from paultyng June 3, 2020 08:44
Copy link
Contributor

@paultyng paultyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we discussed the ctx forking issue internally, and something we can address down the road once things are more stable.

@radeksimko radeksimko merged commit bc69f99 into master Jun 4, 2020
@radeksimko radeksimko deleted the f-configurable-timeout branch June 4, 2020 12:45
@ghost
Copy link

ghost commented Jul 4, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants