fix: continue running jobs even if loading metadata fails #1435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this patch we would skip running a number of jobs, including validation if loading metadata has failed.
Loading metadata can fail for example because
variable
block is incomplete. Theearlydecoder
should already provide partially decoded configuration anyway and hence enable the later validation, so we should not be blocking other jobs based on the failure here as we'd block useful diagnostics.Similar to my other patch, this shouldn't need to be mentioned in the Changelog, since we have not yet exposed this bug to end users since we have not released validation yet.
Before
After