Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue running jobs even if loading metadata fails #1435

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

radeksimko
Copy link
Member

Prior to this patch we would skip running a number of jobs, including validation if loading metadata has failed.

Loading metadata can fail for example because variable block is incomplete. The earlydecoder should already provide partially decoded configuration anyway and hence enable the later validation, so we should not be blocking other jobs based on the failure here as we'd block useful diagnostics.

Similar to my other patch, this shouldn't need to be mentioned in the Changelog, since we have not yet exposed this bug to end users since we have not released validation yet.

Before

Screenshot 2023-10-02 at 18 07 32

After

Screenshot 2023-10-02 at 18 07 10

@radeksimko radeksimko added the bug Something isn't working label Oct 2, 2023
@radeksimko radeksimko requested a review from a team as a code owner October 2, 2023 17:08
@radeksimko radeksimko merged commit 3099737 into main Oct 2, 2023
20 checks passed
@radeksimko radeksimko deleted the fix-metadata-job-failure branch October 2, 2023 17:16
Copy link

github-actions bot commented Nov 2, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants