github: Grant actions: write permission

[radeksimko]

As discovered by @sarahethompson the new v4 version of the action we use now requires this permission.

Not providing the permission leads to those artifacts to not be deleted, which in turn trips up other workflows related to CRT which then attempt to upload these artifacts just because they are in the same path. CRT does not currently have path allowlist to ignore such artifacts but there is an internal feature request.

This is surfaced as the following error:

Error: -15T08:59:29.463Z [ERROR] bob: Failed to download workflow artifact: org=hashicorp repo=terraform-ls error="mkdir .bob/artifacts/registry.terraform.io/1password: permission denied"

In retrospect it does make sense that in order to delete an artifact, one needs write permission of some kind. It is puzzling that this behaviour (requirement of permissions) is dependent on versions.

https://github.com/GeekyEggo/delete-artifact?tab=readme-ov-file#-usage

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.