Combine Stack and Deploy files and diagnostics #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbanck
force-pushed
the
f-stacks-parser-combine
branch
from
e5f44fb
to
0937148
Compare
Base automatically changed from
stacks_static_schema_edits
to
stacks_static_schema
July 5, 2024 12:58
By introducing a generic `Filename` interface, we can combine parsing and storing the ASTs and diagnostics into a single map. With the `StackFilename` and `DeployFilename` type it is still possible to differentiate the files when necessary.
dbanck
force-pushed
the
f-stacks-parser-combine
branch
from
0937148
to
1412aa8
Compare
… stacks is used to refer to *.tstack.hcl files
jpogran
approved these changes
Jul 5, 2024
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By introducing a generic
Filenameinterface, we can combine parsing and storing the ASTs and diagnostics into a single map. With theStackFilenameandDeployFilenametype it is still possible to differentiate the files when necessary.Please treat this as a nice to have suggestion