Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: load embedded provider schemas for providers found in stacks files #1763

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

ansgarm
Copy link
Member

@ansgarm ansgarm commented Jul 12, 2024

Depends on hashicorp/terraform-schema#375


This PR adds a job to load provider schemas that are embedded into the language server binary into state after the early decoder parsed which providers where used in a given stacks project. We will be going to use this information in the schema merger to e.g. enhance provider blocks with their respective attributes within the config block to support hover and completions.

Base automatically changed from pre-release to main July 15, 2024 10:31
@ansgarm ansgarm force-pushed the stacks-load-embedded-schemas branch 2 times, most recently from 1795a82 to 8d3c6d4 Compare July 17, 2024 08:20
@ansgarm ansgarm changed the base branch from main to pre-release July 17, 2024 08:21
@ansgarm ansgarm force-pushed the stacks-load-embedded-schemas branch from 8d3c6d4 to 4bfee50 Compare July 17, 2024 09:22
@ansgarm ansgarm force-pushed the stacks-load-embedded-schemas branch from 4bfee50 to 5eaf791 Compare July 17, 2024 09:45
@ansgarm ansgarm changed the title stacks load embedded schemas feat: load embedded provider schemas for providers found in stacks files Jul 17, 2024
@ansgarm ansgarm requested a review from jpogran July 17, 2024 09:59
@ansgarm ansgarm marked this pull request as ready for review July 17, 2024 10:00
@ansgarm ansgarm requested a review from a team as a code owner July 17, 2024 10:00
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I think it's only missing a separate job type.

internal/features/stacks/events.go Outdated Show resolved Hide resolved
@ansgarm ansgarm force-pushed the stacks-load-embedded-schemas branch from 590b4dc to 0c6c25c Compare July 17, 2024 12:43
@ansgarm ansgarm merged commit 28850e2 into pre-release Jul 17, 2024
6 checks passed
@ansgarm ansgarm deleted the stacks-load-embedded-schemas branch July 17, 2024 15:23
jpogran pushed a commit that referenced this pull request Aug 7, 2024
…les (#1763)

* feat: load embedded provider schemas for providers found in stacks file while early decoding
* Bump terraform-schema to `4ae973d1`
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants