Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface root module init errors on didOpen #187

Closed
wants to merge 3 commits into from
Closed

Conversation

radeksimko
Copy link
Member

I am marking this as draft for now, because I the format of errors it would produce is ... suboptimal due to the fact that error output from terraform providers schema -json is just not designed to be displayed anywhere else outside of the terminal (even after stripping ANSI colour codes).

Screenshot 2020-06-25 at 10 11 08

@radeksimko radeksimko added the enhancement New feature or request label Jun 25, 2020
@aeschright
Copy link
Contributor

Oh yeah, that's a lot to read in a popup window. Are you thinking we could do some cleanup on the language server side of this?

@radeksimko
Copy link
Member Author

Yes, I talked to @kmoe about this too and she mentioned she's tackling similar problem in https://github.com/hashicorp/terraform-exec by essentially regexp-ing known error messages and re-interpreting them as custom error types which have more "consumable" String().

I think that might be good enough solution in the short run, until Terraform exposes this in a more friendly (JSON) format.

@radeksimko
Copy link
Member Author

Closing this in favour of #218

@radeksimko radeksimko closed this Jul 8, 2020
@radeksimko radeksimko deleted the f-surface-errs branch July 21, 2020 11:34
@ghost
Copy link

ghost commented Aug 7, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Aug 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants