ModuleLoader: Avoid deadlock by retrying operation dispatch #393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug which is described in the inline comment. It seems quite unlikely end-user would hit it, but I did manage to hit it in CI test (
TestModuleManager_ModuleCandidatesByPath
) which panicked due to timeout (which I unfortunately do not have available as I retried it and it passed).I also verified at least once that with sufficient pressure the codepath is hit:
but I couldn't get a reliable repro unfortunately.