fix: increase walker queue buffer & start walking early #579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced as part of #502 (i.e. the bug thankfully isn't part of a release)
Due to limited channel buffer size, the walker queueing would be blocked on any 2nd path here:
terraform-ls/internal/langserver/handlers/initialize.go
Line 153 in cf0650f
or here
terraform-ls/internal/langserver/handlers/initialize.go
Line 190 in cf0650f
and it would remain blocked forever as it would also block starting the walker and therefore consumption from the channel.
Attached test times out without the patch.