Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase walker queue buffer & start walking early #579

Merged
merged 2 commits into from
Jul 6, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 6, 2021

This was introduced as part of #502 (i.e. the bug thankfully isn't part of a release)


Due to limited channel buffer size, the walker queueing would be blocked on any 2nd path here:

walker.EnqueuePath(modPath)

or here

walker.EnqueuePath(fh.Dir())

and it would remain blocked forever as it would also block starting the walker and therefore consumption from the channel.

Attached test times out without the patch.

@radeksimko radeksimko added the bug Something isn't working label Jul 6, 2021
@radeksimko radeksimko merged commit d6a0ad5 into main Jul 6, 2021
@radeksimko radeksimko deleted the fix-blocked-walker-queue branch July 6, 2021 13:00
@github-actions
Copy link

github-actions bot commented Aug 6, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant