Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: recognize references in common nested expressions #596

Merged
merged 1 commit into from
Jul 30, 2021
Merged

fix: recognize references in common nested expressions #596

merged 1 commit into from
Jul 30, 2021

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Jul 30, 2021 •
edited
Loading

Fixes #592

This addresses the case of references nested within most common types of expressions (list, set, tuple, object or map). Remaining expression types are to be addressed as part of #496

Before

Screenshot 2021-07-30 at 16 05 40

After

Screenshot 2021-07-30 at 16 06 25

@radeksimko radeksimko added the bug Something isn't working label Jul 30, 2021
@radeksimko radeksimko merged commit db2a7d9 into main Jul 30, 2021
@radeksimko radeksimko deleted the fix-origins-in-common-nested-expr branch July 30, 2021 15:19
@radeksimko radeksimko mentioned this pull request Jul 30, 2021
Closed
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working textDocument/definition textDocument/references textDocument/semanticTokens Semantic syntax highlighting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go to References not working case
1 participant
@radeksimko