Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support standalone (not autoloaded) *.tfvars files #621

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Aug 17, 2021

Closes #562

This PR decouples some logic of the overgrown module package into ast and parser:

  • parser is responsible for parsing *.tf and *.tfvars files - and potentially other future files we will support
  • ast is responsible for representing the files and diagnostics so that they can be filtered accordingly (e.g. we can distinguish between autoloaded and not-autoloaded tfvars files)

@radeksimko radeksimko added the enhancement New feature or request label Aug 17, 2021
@radeksimko radeksimko changed the title Support any *.tfvars files Support standalone (not autoloaded) *.tfvars files Aug 17, 2021
@radeksimko radeksimko marked this pull request as ready for review August 17, 2021 15:12
@@ -1 +1,2 @@
*.go text eol=lf
*.tf text eol=lf
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to avoid test failures (in CI) on Windows caused by converted line endings in test config files.

@radeksimko radeksimko requested a review from a team August 20, 2021 18:10
Copy link
Contributor

@jpogran jpogran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After PR review this looks great!

@radeksimko radeksimko merged commit fd0fc08 into main Aug 25, 2021
@radeksimko radeksimko deleted the f-any-tfvars branch August 25, 2021 15:26
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support standalone (not auto-loaded) tfvars
2 participants