Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental Prefill Required Fields feature #657

Merged
merged 1 commit into from
Oct 7, 2021

Conversation

jpogran
Copy link
Contributor

@jpogran jpogran commented Sep 29, 2021

This adds a new experimental setting for prefilling required fields as blocks are completed from intellisense. For example, completing a resource provider will fill in the required attributes automatically.

Needs hashicorp/hcl-lang#89

internal/langserver/handlers/complete.go Outdated Show resolved Hide resolved
internal/settings/settings.go Outdated Show resolved Hide resolved
@jpogran jpogran self-assigned this Oct 4, 2021
@jpogran jpogran added the enhancement New feature or request label Oct 4, 2021
@jpogran jpogran force-pushed the prefill-required-block branch 3 times, most recently from aa52ea0 to a849645 Compare October 6, 2021 17:33
@jpogran jpogran marked this pull request as ready for review October 6, 2021 17:38
@jpogran jpogran changed the title Prefill Required Attributes Add experimental Prefill Required Fields feature Oct 6, 2021
Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I reckon you'll want to re-pin to the merged revision though, once hashicorp/hcl-lang#89 is merged.

@radeksimko
Copy link
Member

Oh, one last thing - I think we should also document this new experiment here:

https://github.com/hashicorp/terraform-ls/blob/main/docs/SETTINGS.md#experimentalfeatures

It doesn't have to be part of this PR, but we should do it before releasing it, so that we can also link to it from the changelog.

@jpogran
Copy link
Contributor Author

jpogran commented Oct 7, 2021

Updated the pin for hcl-lang, and added detail for the new setting to SETTINGS.md

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

docs/SETTINGS.md Outdated Show resolved Hide resolved
This adds a new experimental setting for prefilling required fields as blocks are completed from intellisense. For example, completing a resource provider will fill in the required attributes automatically.
@github-actions
Copy link

github-actions bot commented Nov 7, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants