Avoid duplicate state entries (by avoiding symlink evaluation) #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
radeksimko
force-pushed
the
b-fix-symlinks
branch
from
7f64cc5
to
3622fa4
Compare
radeksimko
changed the title
We use module paths in many different places and we this ensure we will compare the same paths consistently and avoid duplicate entries in memdb.
radeksimko
force-pushed
the
b-fix-symlinks
branch
from
3622fa4
to
248373c
Compare
dbanck
approved these changes
Nov 18, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use module paths in many different places and this ensures we will compare the same paths consistently and avoid duplicate entries in memdb.
There is unfortunately no easy way to test this as the potential problem would arise as part of a module operation which is executed asynchronously, and/or when publishing diagnostics, which is in itself hard to test currently.
This bug is more visible in #714 and #700 when you open a folder that has symlink somewhere in the path.
We will likely re-evaluate this decision more holistically (in the context of the whole codebase) in #241