Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: decouple diagnostics from handlers into a hook #714

Merged
merged 4 commits into from
Nov 17, 2021

Commits on Nov 16, 2021

  1. Configuration menu
    Copy the full SHA
    b7ce9e9 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Configuration menu
    Copy the full SHA
    bc5d16d View commit details
    Browse the repository at this point in the history
  2. Prevent future deadlocks

    When a (1) capped channel has more than one consumer, one of them will
    effectively remain blocking as the other consumes the message from
    the channel. Closing the channel unblocks any/all consumers.
    
    Here we also unpublish previously public ModuleOperation.Done()
    to further prevent deadlocks in the future, i.e. effectively
    to prevent any place that schedules tasks to wait.
    
    The only reason we keep the channel there for now is to make testing
    *within the package* easier.
    radeksimko committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    806088e View commit details
    Browse the repository at this point in the history
  3. Parse walked module

    Previously we would (mistakenly) not parse module in walker,
    only when it's opened (as part of didOpen or didChange).
    
    This fixes that to help publish diagnostics from all modules
    at startup time.
    radeksimko committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    7611112 View commit details
    Browse the repository at this point in the history