Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip and fix failing tests on Apple Silicon #739

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Dec 13, 2021

Closes #549

The build CI failure can be fixed by #740

@radeksimko radeksimko added bug Something isn't working technical-debt labels Dec 13, 2021
@radeksimko radeksimko requested a review from a team December 14, 2021 07:23
@@ -70,7 +70,7 @@ func newExecutor(t *testing.T) TerraformExecutor {
t.Fatal(err)
}

opts := tfinstall.ExactVersion("0.13.1", installDir)
opts := tfinstall.ExactVersion("1.1.0", installDir)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity 1.0.2 was the first version to support darwin/arm64:
https://releases.hashicorp.com/terraform/1.0.2/

Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@radeksimko radeksimko merged commit 04c8244 into main Dec 14, 2021
@radeksimko radeksimko deleted the fix-apple-silicon branch December 14, 2021 13:41
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working technical-debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestLangServer_workspaceExecuteCommand_modules_multiple fails on aarch64
2 participants