Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add String() for OpTypeDecodeVarsReferences #789

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Conversation

radeksimko
Copy link
Member

This is mostly for convenience in debug messages, which otherwise come through as not-very-descriptive OpType(9).

@radeksimko radeksimko added the enhancement New feature or request label Feb 11, 2022
@radeksimko radeksimko requested a review from a team February 11, 2022 11:42
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I think I missed running some code generation when adding the variable reference back then?

@radeksimko
Copy link
Member Author

I think I missed running some code generation when adding the variable reference back then?

go generate internal/terraform/module/operation

is the magic command.

And yeah - it's easy to miss - I suppose we could add some checks in CI, but given how often we add new types I'm not sure it's worth the effort. 🤷🏻

@radeksimko radeksimko merged commit 526f22c into main Feb 11, 2022
@radeksimko radeksimko deleted the regenerate-op-types branch February 11, 2022 13:11
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants