Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/lsp: fix encoding of unknown semantic token types #815

Merged
merged 3 commits into from
Mar 2, 2022
Merged

internal/lsp: fix encoding of unknown semantic token types #815

merged 3 commits into from
Mar 2, 2022

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Mar 2, 2022 •
edited
Loading

@radeksimko radeksimko added bug Something isn't working textDocument/semanticTokens Semantic syntax highlighting workspace/semanticTokens labels Mar 2, 2022
@radeksimko radeksimko added this to the v0.26.0 milestone Mar 2, 2022
@radeksimko radeksimko requested a review from a team March 2, 2022 09:29
@radeksimko radeksimko requested a review from dbanck March 2, 2022 11:13
dbanck
dbanck approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@dbanck dbanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@radeksimko radeksimko merged commit e1bc81d into main Mar 2, 2022
@radeksimko radeksimko deleted the b-unknown-sem-token-type branch March 2, 2022 11:38
@radeksimko radeksimko self-assigned this Mar 2, 2022
@github-actions
Copy link

This functionality has been released in v0.26.0 of the language server.
If you use the official Terraform VS Code extension, it will prompt you to upgrade to this version automatically upon next launch or within the next 24 hours.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbanck dbanck dbanck approved these changes

Assignees

@radeksimko radeksimko

Labels
bug Something isn't working textDocument/semanticTokens Semantic syntax highlighting workspace/semanticTokens
Projects
None yet
Milestone
v0.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@radeksimko @dbanck