cmd: Remove completion CLI command
#852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
changed the title
completion CLI command
|
This functionality has been released in v0.27.0 of the language server. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
This command was added in the early versions of LS primarily for debugging purposes of completion. We have since gotten more confident in the completion logic and also in the client-side, either reducing the need to debug or using the VS Code extension w/ log for debugging instead.
Finally @dbanck published https://github.com/dbanck/go-lsp-test which can further aid debugging with any LSP feature and act as a language client.
Keeping the command around also makes refactoring often more difficult than necessary.
Just for clarity for anyone less familiar with the codebase landing here - this is removing a
completionCLI command, not completion functionality, which of course remains available via LSP (as exposed viaserveCLI command).